Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #178 by introducing an enum for special allowance of static initializer #184

Closed
wants to merge 2 commits into from
Closed

fix #178 by introducing an enum for special allowance of static initializer #184

wants to merge 2 commits into from

Conversation

simonbasle
Copy link
Member

This PR is an alternative to #179, exploring an enum rather than a builder spec.

@simonbasle simonbasle added area/java-agent type/documentation A documentation update type/enhancement A general enhancement labels Mar 29, 2021
@simonbasle simonbasle self-assigned this Mar 29, 2021
@simonbasle simonbasle requested a review from a team March 29, 2021 09:27
@simonbasle simonbasle mentioned this pull request Mar 29, 2021
Closed
@simonbasle
Copy link
Member Author

cc @rstoyanchev @bsideup

bsideup
bsideup suggested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still go with "just documented", to keep our public API surface small.

Also, disallow is missing.

@simonbasle simonbasle closed this Mar 29, 2021
@simonbasle simonbasle deleted the 178-simplifyAllowanceStaticInit branch March 29, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup requested changes

Assignees

@simonbasle simonbasle

Labels
area/java-agent type/documentation A documentation update type/enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonbasle @bsideup