-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate reference documentation to Antora
#3120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force-pushed for centralizing antora versions in top level build.gradle |
violetagg
reviewed
Mar 27, 2024
violetagg
reviewed
Mar 27, 2024
@pderop Nice! Let's merge it! |
violetagg
approved these changes
Apr 1, 2024
@violetagg , thank you for your review ! |
violetagg
added
type/documentation
A documentation update
and removed
type/enhancement
A general enhancement
labels
Apr 2, 2024
violetagg
changed the title
Migrate 1.2.x doc to Antora
Migrate reference documentation to Antora
Apr 2, 2024
pderop
added a commit
that referenced
this pull request
Apr 2, 2024
violetagg
changed the title
Migrate reference documentation to Antora
Migrate reference documentation to Apr 3, 2024
Antora
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is first attempt to migrate Reactor Netty 1.2.x documentation to Antora
There are three logical commits in this PR:
To test this PR, you can proceed like the following:
Testing without PDF:
Testing with PDF:
As before, PDF are not generated by default in snapshot mode. If you want to also include a PDF in the generated docs zip, then do the following: