Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to the examples #3133

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add links to the examples #3133

merged 2 commits into from
Apr 3, 2024

Conversation

violetagg
Copy link
Member

  • Remove unnecessary attributes
  • Add global attribute for the source type

@violetagg
[doc] Add links to the examples
6e35634 
- Remove unnecessary attributes
- Add global attribute for the source type
@violetagg violetagg added the type/documentation A documentation update label Apr 3, 2024
@violetagg violetagg added this to the 1.2.0-M1 milestone Apr 3, 2024
@violetagg violetagg requested a review from a team April 3, 2024 12:21
@violetagg
Copy link
Member Author

The failing CI is not related as this change is only related to the documentation.

pderop
pderop approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
(see few comments, I'm proposing to move the source-language attribute to antora.yml)

docs/modules/ROOT/pages/http-client.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/http-server.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/tcp-client.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/tcp-server.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/udp-client.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/udp-server.adoc Outdated Show resolved Hide resolved
@violetagg
Copy link
Member Author

+1 (see few comments, I'm proposing to move the source-language attribute to antora.yml)

I moved also several other attribute in antora.yml
Please check again

pderop
pderop approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@violetagg
Copy link
Member Author

The failing CI is not related as this change is only related to the documentation.

@violetagg violetagg merged commit 8a31d1f into main Apr 3, 2024
12 of 14 checks passed
@violetagg violetagg deleted the links-to-examples branch April 3, 2024 14:24
violetagg added a commit that referenced this pull request Apr 3, 2024
@violetagg
Merge #3133 into 2.0.0-M4
bae19e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/documentation A documentation update
Projects
None yet
Milestone
1.2.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@violetagg @pderop