When terminating detach the connection from request/response objects #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violetagg
force-pushed
the
issue-3416
branch
2 times, most recently
from
c1741b8 to
68f0b2a
Compare
|
@chemicL wait with the review - some of the tests are failing ... |
|
@chemicL This PR is ready for a review. I'm targeting not the release next week but the release in November. |
chemicL
approved these changes
Oct 10, 2024
reactor-netty-core/src/main/java/reactor/netty/channel/ChannelOperations.java
Outdated
Show resolved
Hide resolved
reactor-netty-http-brave/src/main/java/reactor/netty/http/brave/TracingHttpServerDecorator.java
Show resolved
Hide resolved
reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
Show resolved
Hide resolved
…e the real connection Obtain the event loop outside of doFinally when we have the real connection
|
@chemicL I think I addressed your feedback |
|
@chemicL Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Oct 17, 2024
violetagg
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3416, #3367