Should we release 0.66.4?

[lunaleaps]

0.66.4 has been released

See discussion about 0.66.5 here: #8

Current Release: 0.66.3

Conversations on this thread are limited to 0.66 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into main but did not make the 0.66.3 cut, with a link to the specific commit hash on main with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.

List of cherry picks

1. Cherry pick "Fix post_install_workaround downgrading development targets" to 0.66-stable facebook/react-native#32715
2. Revert "Fix Deadlock in RCTi18nUtil (iOS) (#31032)" (#32574) facebook/react-native#32714

Local commits to backport to main

[Yonom]

The __apply_Xcode_12_5_M1_post_install_workaround script causes problems if one has pods targetting 12.0 or higher. Can you consider picking this fix? facebook/react-native@a4a3e67

[lunaleaps]

Do you mind making a PR against the 0.66-stable branch?

[Yonom]

Done! facebook/react-native#32715

[Yonom]

@mmmoussa suggested picking this commit for rtl support: facebook/react-native@70ddf46

[mmmoussa]

v0.66.0 broke rtl support on iOS, meaning our app's core experience is currently broken for all iOS rtl users.

[lunaleaps]

Do you mind making a PR against the 0.66-stable branch?

[mmmoussa]

facebook/react-native#32714

[mmmoussa]

@lunaleaps is v0.66.4 planned for release soon?

[mmmoussa]

@mikehardy thanks for your suggestion, and @kelset thanks for checking.

[lunaleaps]

Hey guys, yes I was thinking of doing a 0.66.4 update given that 67 isn't going to be out this year. I wanted to wait until Wednesday/Thurs to create the build in case there were any other picks. Also consulting with others if it's a good idea.

Thanks for your understanding and sorry I should've communicated that better!

[lunaleaps]

Actually another thing, for your pick PRs, we should be creating commitlies on them so people can use those versions (more of a realization for myself than anything). However this might not be true for 0.66 (I can't recall when @hramos added commitly support) but note to self to check that pick PRs do build artifacts

[kelset]

@lunaleaps yeah I was thinking the same about commitlies but I checked the branch and the CI jobs and I couldn't see the one generating... but maybe I didn't look close enough 😓

[mmmoussa]

@lunaleaps will there be a 0.66.4 going out today or tomorrow?

[arunim2405]

If you guys do decide to release 0.66.4, can you guys please also include this commit. thanks for all the good work. 🙌

[lunaleaps]

Can you clarify why it's a blocking issue for you using 0.66 and also can you make a PR against 0.66-stable? Thanks!

[arunim2405]

This pr explains the use of the commit very well, will make a PR against 0.66-stable soon 👍

[arunim2405]

@lunaleaps facebook/react-native#32725

[billnbell]

Getting split issues with Ruby... ?

Generating Pods project
[!] An error occurred while processing the post-install hook of the Podfile.

undefined method `split' for nil:NilClass

/Users/bill/theclub/TheClub/node_modules/react-native/scripts/react_native_pods.rb:241:in `block (2 levels) in __apply_Xcode_12_5_M1_post_install_workaround'
/Users/bill/theclub/TheClub/node_modules/react-native/scripts/react_native_pods.rb:239:in `each'
/Users/bill/theclub/TheClub/node_modules/react-native/scripts/react_native_pods.rb:239:in `block in __apply_Xcode_12_5_M1_post_install_workaround'
/Users/bill/theclub/TheClub/node_modules/react-native/scripts/react_native_pods.rb:238:in `each'
/Users/bill/theclub/TheClub/node_modules/react-native/scripts/react_native_pods.rb:238:in `__apply_Xcode_12_5_M1_post_install_workaround'
/Users/bill/theclub/TheClub/ios/Podfile:40:in `block (3 levels) in from_ruby'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-core-1.11.2/lib/cocoapods-core/podfile.rb:196:in `post_install!'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:945:in `run_podfile_post_install_hook'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:933:in `block in run_podfile_post_install_hooks'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/user_interface.rb:149:in `message'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:932:in `run_podfile_post_install_hooks'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:331:in `block (2 levels) in create_and_save_projects'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer/xcode/pods_project_generator/pods_project_writer.rb:61:in `write!'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:330:in `block in create_and_save_projects'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/user_interface.rb:64:in `section'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:309:in `create_and_save_projects'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:301:in `generate_pods_project'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:180:in `integrate'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/installer.rb:167:in `install!'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/command/install.rb:52:in `run'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/lib/cocoapods/command.rb:52:in `run'
/Users/bill/.rvm/gems/ruby-2.7.4/gems/cocoapods-1.11.2/bin/pod:55:in `<top (required)>'
/Users/bill/.rvm/gems/ruby-2.7.4/bin/pod:23:in `load'
/Users/bill/.rvm/gems/ruby-2.7.4/bin/pod:23:in `<main>'
/Users/bill/.rvm/gems/ruby-2.7.4/bin/ruby_executable_hooks:22:in `eval'
/Users/bill/.rvm/gems/ruby-2.7.4/bin/ruby_executable_hooks:22:in `<main>'

[billnbell]

Here is how you can do it

should_upgrade = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].to_f < 11.0 && config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].to_f != 0.0

[billnbell]

diff --git a/node_modules/react-native/scripts/react_native_pods.rb b/node_modules/react-native/scripts/react_native_pods.rb
index df31139..71d1993 100644
--- a/node_modules/react-native/scripts/react_native_pods.rb
+++ b/node_modules/react-native/scripts/react_native_pods.rb
@@ -238,7 +238,7 @@ def __apply_Xcode_12_5_M1_post_install_workaround(installer)
   installer.pods_project.targets.each do |target|
     target.build_configurations.each do |config|
       # ensure IPHONEOS_DEPLOYMENT_TARGET is at least 11.0
-      should_upgrade = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].split('.')[0].to_i < 11
+      should_upgrade = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].to_f < 11.0 && config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].to_f != 0.0
       if should_upgrade
         config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '11.0'
       end

[billnbell]

I tested it on some bad pods, and it works great.

[kelset]

Can either of you submit a PR for this?

[Yonom]

@kelset facebook/react-native#32746 (targetting main), facebook/react-native#32747 (targetting 0.66-stable)

[billnbell]

ok can we release it?