Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when pod has no IPHONEOS_DEPLOYMENT_TARGET (0.66-stable) #32747

Closed
wants to merge 1 commit into from
Closed

Fix error when pod has no IPHONEOS_DEPLOYMENT_TARGET (0.66-stable) #32747

wants to merge 1 commit into from

Conversation

Yonom
Copy link
Contributor

@Yonom Yonom commented Dec 13, 2021

Co-Authored-By: William Bell williambell9708@outlook.com

ℹ️ This is a cherry-pick of #32746 to 0.66-stable

Summary

If one of the pods has no IPHONEOS_DEPLOYMENT_TARGET, the M1 postinstall workaround script fails. This commit updates the code to handle this special case.

Changelog

[iOS] [Fixed] - __apply_Xcode_12_5_M1_post_install_workaround failing when one of the Pods has no IPHONEOS_DEPLOYMENT_TARGET set

Test Plan

reactwg/react-native-releases#6 (reply in thread)

Co-Authored-By: William Bell <williambell9708@outlook.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2021
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Dec 13, 2021
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against 7bd0100

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 34efaab

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,942,998 +649,741
android hermes armeabi-v7a 8,477,897 +854,170
android hermes x86 9,362,010 +598,152
android hermes x86_64 9,329,251 +626,432
android jsc arm64-v8a 10,626,434 +944,770
android jsc armeabi-v7a 9,548,844 +880,012
android jsc x86 10,639,735 +1,001,953
android jsc x86_64 11,250,649 +1,016,315

Base commit: 34efaab

@Yonom
Copy link
Contributor Author

Yonom commented Feb 3, 2022

Closing due to inactivity.

@Yonom Yonom closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants