-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal "Format API" #127
Merged
mickael-menu
merged 7 commits into
readium:master
from
mickael-menu:proposal/file-format-api
May 5, 2020
Merged
Add proposal "Format API" #127
mickael-menu
merged 7 commits into
readium:master
from
mickael-menu:proposal/file-format-api
May 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2020
mickael-menu
commented
Mar 23, 2020
qnga
reviewed
Mar 24, 2020
qnga
reviewed
Mar 24, 2020
mickael-menu
changed the title
Initial proposal for the File and Format API
Add proposal "File and Format API"
Mar 30, 2020
mickael-menu
changed the title
Add proposal "File and Format API"
Add proposal "Format API"
Apr 1, 2020
mickael-menu
requested review from
danielweck,
HadrienGardeur,
llemeurfr,
JayPanoz and
jccr
April 1, 2020 16:16
@danielweck @jccr We would like to merge this proposal during the next Readium dev call, so any insights you may have for desktop and web is most welcomed 🙏 |
mickael-menu
commented
Apr 11, 2020
HadrienGardeur
approved these changes
Apr 22, 2020
I'd like to move forward, so I intend to merge this proposal after next week's meeting, if there's no counter-arguments till then. I made a few changes in the proposal after implementing it in Swift:
|
This was referenced Apr 29, 2020
Change the ZAB media type Fix EPUB heavy sniffing
Add the x. facet for ZAB and W3C WPUB
Renamed Format.guess into Format.of Added bitmap formats, used for the CBZ parser Removed `inspectingContent` parameter to simplify the sniffers Grouped formats in shared sniffers
Add `Link.mediaType` helper Add `Format.SnifferContext` `encoding`, `contentAsRWPM` and `readFileSignature()`
Add MediaType's isAudio and isLCPProtected Add OPDS Authentication Document media type and format Sniff an Audiobook using the reading order types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal introduces a dedicated API to easily figure out a file format.
While a
Publication
is independent of any particular format, knowing the format of a publication file is necessary to:This API is not tied to
Publication
, so it can be used as a general purpose tool to guess a file format, e.g. during HTTP requests or in the LCP library.You can read the formatted proposal here.