* Dependency "ta-json" GitHub semver dependency becomes "ta-json-x" N…

…PM package (fixes #10 ) * Removed TypeScript linter warning message (checks for no unused variables) * NPM updates related to the Node TypeScript typings
readium · Oct 2, 2018 · 52e3568 · 52e3568
1 parent e5f2310
commit 52e3568
Show file tree

Hide file tree

Showing 8 changed files with 411 additions and 365 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,23 @@
 Git diff:
 * https://github.com/readium/r2-testapp-js/compare/v1.0.0-alpha.5...develop
 
+# 1.0.0-alpha.6
+
+Changes:
+* Dependency "ta-json" GitHub semver dependency becomes "ta-json-x" NPM package (fixes https://github.com/readium/r2-testapp-js/issues/10 )
+* Removed TypeScript linter warning message (checks for no unused variables)
+* NPM updates related to the Node TypeScript typings
+
+Git revision info:
+* https://unpkg.com/r2-testapp-js@1.0.0-alpha.6/dist/gitrev.json
+* https://github.com/edrlab/r2-testapp-js-dist/blob/v1.0.0-alpha.6/dist/gitrev.json
+
+Git commit history:
+* https://github.com/readium/r2-testapp-js/commits/v1.0.0-alpha.6
+
+Git diff:
+* https://github.com/readium/r2-testapp-js/compare/v1.0.0-alpha.5...v1.0.0-alpha.6
+
 # 1.0.0-alpha.5
 
 Changes:

diff --git a/package-lock.json b/package-lock.json
diff --git a/package-scripts-bundle.cson b/package-scripts-bundle.cson
@@ -249,14 +249,14 @@
     ((ls ./node_modules/reflect-metadata/ &&
     cpy ./Reflect.ts ./node_modules/reflect-metadata/) || echo "OK") &&
 
-    ((ls ./node_modules/ta-json/node_modules/reflect-metadata/ &&
-    cpy ./Reflect.ts ./node_modules/ta-json/node_modules/reflect-metadata/) || echo "OK") &&
+    ((ls ./node_modules/ta-json-x/node_modules/reflect-metadata/ &&
+    cpy ./Reflect.ts ./node_modules/ta-json-x/node_modules/reflect-metadata/) || echo "OK") &&
 
-    ((ls ./node_modules/r2-navigator-js/node_modules/ta-json/node_modules/reflect-metadata/ &&
-    cpy ./Reflect.ts ./node_modules/r2-navigator-js/node_modules/ta-json/node_modules/reflect-metadata/) || echo "OK") &&
+    ((ls ./node_modules/r2-navigator-js/node_modules/ta-json-x/node_modules/reflect-metadata/ &&
+    cpy ./Reflect.ts ./node_modules/r2-navigator-js/node_modules/ta-json-x/node_modules/reflect-metadata/) || echo "OK") &&
 
-    ((ls ./node_modules/r2-streamer-js/node_modules/ta-json/node_modules/reflect-metadata/ &&
-    cpy ./Reflect.ts ./node_modules/r2-streamer-js/node_modules/ta-json/node_modules/reflect-metadata/) || echo "OK") &&
+    ((ls ./node_modules/r2-streamer-js/node_modules/ta-json-x/node_modules/reflect-metadata/ &&
+    cpy ./Reflect.ts ./node_modules/r2-streamer-js/node_modules/ta-json-x/node_modules/reflect-metadata/) || echo "OK") &&
 
     rimraf Reflect.ts &&
 

diff --git a/package.json b/package.json
diff --git a/src/electron/main/index.ts b/src/electron/main/index.ts
@@ -50,7 +50,7 @@ import * as filehound from "filehound";
 import * as portfinder from "portfinder";
 import * as request from "request";
 import * as requestPromise from "request-promise-native";
-import { JSON as TAJSON } from "ta-json";
+import { JSON as TAJSON } from "ta-json-x";
 
 import { R2_EVENT_DEVTOOLS } from "../common/events";
 import { IStore } from "../common/store";

diff --git a/src/electron/renderer/index.ts b/src/electron/renderer/index.ts
@@ -40,7 +40,7 @@ import {
 } from "@r2-shared-js/init-globals";
 import { encodeURIComponent_RFC3986 } from "@utils/http/UrlUtils";
 import { ipcRenderer, webFrame } from "electron";
-import { JSON as TAJSON } from "ta-json";
+import { JSON as TAJSON } from "ta-json-x";
 
 import {
     IEventPayload_R2_EVENT_LCP_LSD_RENEW,

diff --git a/tsconfigs/tsconfig-common.json b/tsconfigs/tsconfig-common.json
@@ -8,7 +8,7 @@
         "alwaysShowRuleFailuresAsWarnings": false,
         "ignoreDefinitionFiles": true,
         "configFile": "./tslint.json",
-        "disableNoUnusedVariableRule": true
+        "disableNoUnusedVariableRule": false
       }
     ],
     "rootDir": "../",

diff --git a/tslint.json b/tslint.json
@@ -5,7 +5,6 @@
     "no-floating-promises": true,
     "promise-function-async": true,
     "await-promise": true,
-    "no-unused-variable": true,
     "no-unused-expression": true,
     "variable-name": [
       true,