Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous / next page buttons obscure content (links, Media Overlays click, scrollview bar, text selection / annotations, etc.) #109

Closed
danielweck opened this issue Jul 28, 2014 · 2 comments
Closed

Previous / next page buttons obscure content (links, Media Overlays click, scrollview bar, text selection / annotations, etc.) #109

danielweck opened this issue Jul 28, 2014 · 2 comments

Comments

@danielweck
Copy link
Member

No description provided.

danielweck added a commit that referenced this issue Jul 28, 2014
@danielweck
addresses #109, but must work in conjunction with other readium-share…
417b7f1 
…d-js code for reflowable column spacing
@danielweck danielweck changed the title Previous / next page buttons obscure content (links, Media Overlays click, text selection / annotations, etc.) Previous / next page buttons obscure content (links, Media Overlays click, scrollview bar, text selection / annotations, etc.) Jul 28, 2014
@danielweck
Copy link
Member Author

Addressed in 417b7f1

Note that for reflowable content, the "textWidthMargins" feature branch provides better handling of the left/right spacing based on column gap:
https://github.com/readium/readium-js-viewer/tree/feature/textWidthMargins
https://github.com/readium/readium-shared-js/tree/feature/textWidthMargins

@danielweck danielweck added this to the v1 milestone Jul 31, 2014
This was referenced Aug 7, 2014
Merged
Merged
Merged
@danielweck
Copy link
Member Author

Fixed by Pull Request:
readium/readium-shared-js#93
readium/readium-js#68
#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck