Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips not showing up quick enough, only mouse over #155

Closed
danielweck opened this issue Aug 8, 2014 · 5 comments
Closed

Tooltips not showing up quick enough, only mouse over #155

danielweck opened this issue Aug 8, 2014 · 5 comments
Assignees

Comments

@danielweck
Copy link
Member

http://getbootstrap.com/javascript/#tooltips

@danielweck
Copy link
Member Author

@becka11y can you please check whether my proposed implementation is satisfactory? Many thanks!

Feature branch:
https://github.com/readium/readium-js-viewer/tree/feature/tooltips

Pull Request:
#156

@becka11y
Copy link
Contributor

I've tested with VoiceOver in Chrome and Safari and it works fine. Except, there is a typo in library-navbar.html - the Add to library button has the attribute name as arial-label (note the extra letter el). This prevents the button name/label from being spoken by VoiceOver.

@danielweck
Copy link
Member Author

Thanks @becka11y, filed and fixed:
#158

@ryanackley
Copy link
Contributor

I just pushed a fix to develop branch loosely based on Daniel's branch. Let me know if it's not what you had in mind.

@danielweck
Copy link
Member Author

Thanks @ryanackley
I tested the tooltips and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants