Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: keyboard shortcuts fail when focus is within content iframe #185

Closed
danielweck opened this issue Aug 31, 2014 · 3 comments
Closed

Regression: keyboard shortcuts fail when focus is within content iframe #185

danielweck opened this issue Aug 31, 2014 · 3 comments
Assignees
@danielweck

Comments

@danielweck
Copy link
Member

I am not sure what commit introduced this regression yet ... investigating.
@danielweck danielweck self-assigned this Aug 31, 2014
@danielweck danielweck modified the milestones: v1, v1+ Aug 31, 2014
@danielweck
Copy link
Member Author

Chrome Extension seems to work fine, Safari and Chrome OSX web browsers fail. Moving to v1+

danielweck added a commit that referenced this issue Aug 31, 2014
@danielweck
Fixes #185
2d577ea 
Regression: keyboard shortcuts fail when focus is within content iframe (cloud reader only, not chrome app)
@danielweck
Copy link
Member Author

"Fixed" here:
2d577ea

...but we need to understand why the ZIP iframe loader doesn't forward iframe events correctly. Thus why this issue is kept open for now.

See:
https://github.com/readium/readium-shared-js/blob/develop/js/views/iframe_loader.js

https://github.com/readium/readium-js/blob/develop/epub-modules/epub-fetch/src/models/iframe_zip_loader.js

danielweck added a commit that referenced this issue Aug 31, 2014
@danielweck
restored correct iframe loader for cloud reader (was testing for issue …
c96a907 
…#185)
danielweck added a commit to readium/readium-js that referenced this issue Aug 31, 2014
@danielweck
fixes
2a6e59f 
readium/readium-js-viewer#185
(iframe events forward)
@danielweck
Copy link
Member Author

The ZIP iframe loader was incorrectly registering iframe events. Fixed here:
readium/readium-js@2a6e59f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielweck danielweck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck