Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing lib/thirdparty/inflate.js external files in cloud reader builds #271

Merged
merged 2 commits into from
Jan 26, 2015
Merged

Missing lib/thirdparty/inflate.js external files in cloud reader builds #271

merged 2 commits into from
Jan 26, 2015

Conversation

danielweck
Copy link
Member

Addresses #270

@danielweck
added Grunt option so that the cloud reader builds can specify the lo…
6502e0e 
…cation of the zip (inflate/deflate) lib that is used by the Web Worker when reading a packed EPUB archive
@danielweck
updated build
d7258d7
@danielweck
Copy link
Member Author

Notes:

  • Tested the Chrome extension / app: no regression bugs when importing a packed EPUB (unzipping completes successfully).
  • Tested the non-optimized index.html and simpleviewer.html to open zipped EPUBs: works fine.
  • Tested the optimized (minified and aggregated source code) build/cloud-reader/index.html and build/cloud-reader-lite/index.html to open zipped EPUBs: works fine.

e.g. from Node-Express (using the no-parameters grunt command):

http://127.0.0.1:8080/index.html?epub=epub_content/internal_link.epub

http://127.0.0.1:8080/simpleviewer.html?epub=epub_content/internal_link.epub

http://127.0.0.1:8080/build/cloud-reader/index.html?epub=../../epub_content/internal_link.epub

http://127.0.0.1:8080/build/cloud-reader-lite/index.html?epub=../../epub_content/internal_link.epub

ryanackley added a commit that referenced this pull request Jan 26, 2015
@ryanackley
Merge pull request #271 from readium/feature/zipLibsCloudReaderBuild
284646d 
Missing lib/thirdparty/inflate.js external files in cloud reader builds
@ryanackley ryanackley merged commit 284646d into develop Jan 26, 2015
@danielweck danielweck mentioned this pull request Jan 26, 2015
Closed
@danielweck danielweck deleted the feature/zipLibsCloudReaderBuild branch January 26, 2015 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielweck @ryanackley