fixes #542 - no message when invalid keyboard shortcuts saved #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the message box to contain the appropriate messages for saving and/or when one of the keyboard shortcuts was tagged with INVALID or DUPLICATE when the shortcuts were saved. Will require translation of a new message string currently only add to en_US/messages.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Instructions
Add new message for when the Keyboard Shortcut settings is saved but some of the settings are INVALID or DUPLICATE
This pull request is a Work In Progress
until we agree upon the wording of the new message
Related issue(s) and/or pull request(s)
Example: See also #533 This message dialog will not trap focus until 533 is fixed.
Test cases, sample files
Test by opening the keyboard shortcuts pane of the settings dialog.
Change the value of one of the settings to one that is already used by another shortcut. DUPLICATE will appear in the field. Press Save Changes - you should see a dialog with a message that the INVALID or DUPLICATE setting was restored to the original.
If a setting was legitimately changed and another was INALID or DUPLICATE when the settings were saved, two messages will be displayed in the dialog.
Test combinations of just
2)correclty changing a shortcut and also having one in error - two messages are displayed
3)correctly changing 1 or more shortcuts - just one reload message is displayed
Additional information
I updated the message box to contain the appropriate messages
for saving and/or when one of the keyboard shortcuts was
tagged with INVALID or DUPLICATE when the shortcuts were saved.
Will require translation of a new message string currently only
add to en_US/messages.json