XML to HTML tag fix. #136
Open
XML to HTML tag fix. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matwood
commented
Feb 29, 2016
matwood
commented
- The method used to load the spine items into iframes for IE does not (cannot?) maintain the content type. All documents end up being treated as HTML. This breaks EPUBs (in particular the CFI generation) that leverage XML since many self closed tags are invalid in HTML.
- The 'fix'/hack for now is to parse the spine item and replace invalid self closing tags with html valid closing tags.
- After a slack discussion it was decided to do this for all browsers to maintain consistency.
* The method used to load the spine items into iframes for IE does not * (cannot?) maintain the content type. All documents end up being treated * as HTML. This breaks EPUBs (in particular the CFI generation) that leverage * XML since many self closed tags are invalid in HTML. * The 'fix'/hack for now is to parse the spine item and replace invalid * self closing tags with html valid closing tags.
|
I did not run tests on this regexp routine, but it looks good to me. |
|
Found a problem with the original regex that broke when a newline was inside the tag. This fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.