-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Overlays + scroll view: user-invoked scroll => playback shifts to visible element #57
Comments
3 options when user "manually" scrolls the viewport:
Side issue: this configurable user setting (preference dialog or top-level MO UI switch) may also impact paginated reflowable view (i.e. when switching page, obviously there is no "user scroll" interaction). |
Related issue: |
For options (1) and (2) above: https://github.com/readium/readium-shared-js/blob/develop/js/views/media_overlay_player.js#L1543 ==> An additional condition is needed for call to reader.insureElementVisibility(), which in the case of the scroll view, results in: https://github.com/readium/readium-shared-js/blob/develop/js/views/scroll_view.js#L1290 ...and for the paginated view: https://github.com/readium/readium-shared-js/blob/develop/js/views/reflowable_view.js#L718 ...fixed layout view assume "always visible": https://github.com/readium/readium-shared-js/blob/develop/js/views/fixed_view.js#L651 |
Setting would need to be implemented here: https://github.com/readium/readium-shared-js/blob/develop/js/models/viewer_settings.js#L34 ...and UI affordance in readium-js-viewer: https://github.com/readium/readium-js-viewer/blob/master/lib/EpubReaderMediaOverlays.js |
The default behaviour seems reasonable if the assumed use case is to follow along with the text being read. I don't think I can actively listen and jump around the book. |
Hi @dmitrym0, there is a high-importance feature request for use-case (2), namely: manual scroll to peek at content (e.g. image, diagrams) after or before currently-spoken text. Note that there is no js-viewer UI yet to control this option. |
This default behaviour can actually get really annoying, especially when users try to "look around" before or after the current playback position.
The text was updated successfully, but these errors were encountered: