Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #496

Merged
merged 6 commits into from
May 16, 2022
Merged

chore: update deps #496

merged 6 commits into from
May 16, 2022

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented May 16, 2022

PR App Resolves #495

🧰 Changes

Updates a bunch of dependencies. We're stuck not updating any remark/unified until we can do a big rewrite. And we're also stuck not updating react until some other deps do too?

This update also as a .npm-upgrade.json file. I typically use npm-upgrade to do batch updates, so this is finally checking that file in.

This also changes the snapshot comparison from per pixel to SSIM. This was motivated by a new change in how the embeds thumbnail was being rendered. The thumbnail appears to be blurred vs pixelated depending on which node version it is. I believe this has more to do with puppeteer than any of the production code. Plus, I'd just like to see how this method works out.

🧬 QA & Testing

@@ -0,0 +1,84 @@
{
"ignore": {
"hast-util-to-string": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add these to the dependabot config too

@github-actions
Copy link

A review app has been launched for this PR!

🔍 Inspect the app: https://dashboard.heroku.com/apps/markdown-pr-496

🧭 Take it for a spin: https://markdown-pr-496.herokuapp.com/

@github-actions
Copy link

This PR‘s review app has been redeployed!

🔍 Inspect the app: https://dashboard.heroku.com/apps/markdown-pr-496

🧭 Take it for a spin: https://markdown-pr-496.herokuapp.com/

@github-actions
Copy link

This PR‘s review app has been redeployed!

🔍 Inspect the app: https://dashboard.heroku.com/apps/markdown-pr-496

🧭 Take it for a spin: https://markdown-pr-496.herokuapp.com/

@github-actions
Copy link

This PR‘s review app has been redeployed!

🔍 Inspect the app: https://dashboard.heroku.com/apps/markdown-pr-496

🧭 Take it for a spin: https://markdown-pr-496.herokuapp.com/

@github-actions
Copy link

This PR‘s review app has been redeployed!

🔍 Inspect the app: https://dashboard.heroku.com/apps/markdown-pr-496

🧭 Take it for a spin: https://markdown-pr-496.herokuapp.com/

@kellyjosephprice kellyjosephprice marked this pull request as ready for review May 16, 2022 19:54
@kellyjosephprice kellyjosephprice requested review from erunion, rafegoldberg and thenaomiday and removed request for erunion May 16, 2022 19:55
@kellyjosephprice kellyjosephprice merged commit 41b8935 into next May 16, 2022
@kellyjosephprice kellyjosephprice deleted the package-updates branch May 16, 2022 20:08
@github-actions
Copy link

This PR’s review app has been shut down.

🧽 Since this PR is closed, its review app has been cleaned up.

rafegoldberg pushed a commit that referenced this pull request May 23, 2022
## Version 6.41.0

### 🛠 Fixes & Updates

* auto-open review apps on Heroku ([#494](#494)) ([427c917](427c917))
* don't run Review App workflow on Markdown PRs opened by Dependabot ([#506](#506)) ([53865bd](53865bd))
* update deps ([#496](#496)) ([41b8935](41b8935))

### ✨ New & Improved

* add yaml compiler ([#509](#509)) ([ac238d1](ac238d1))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.41.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React processor throws "ReferenceError: process is not defined"
4 participants