Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

refactor: use lodash-es over lodash #242

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Sep 21, 2023

🧰 Changes

Fixes an issue I saw when attempting to bump this package dep in readmeio/api#735:

image

🧬 QA & Testing

This project is ESM already so I think this should be a patch change. If tests pass then I think we should be good to go!

@kanadgupta kanadgupta added dependencies Pull requests that update a dependency file refactor Issues about tackling technical debt labels Sep 21, 2023
@kanadgupta kanadgupta marked this pull request as ready for review September 21, 2023 18:42
@kanadgupta kanadgupta merged commit a10197a into main Sep 21, 2023
7 checks passed
@kanadgupta kanadgupta deleted the refactor/use-lodash-es branch September 21, 2023 18:43
@@ -10,7 +10,6 @@

"unicorn/prefer-node-protocol": "error",

"you-dont-need-lodash-underscore/get": "off",
"you-dont-need-lodash-underscore/set": "off"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rule doesn't exist!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant