This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
fix: don't use module #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2023
erunion
reviewed
Oct 5, 2023
| @@ -322,7 +321,7 @@ function encodeObject({ location, key, value, style, explode, escape, isAllowedR | |||
| */ | |||
| function encodePrimitive({ location, key, value, style, escape, isAllowedReserved = false }: StylizerConfig) { | |||
| const valueEncoder = (str: string) => | |||
| module.exports.encodeDisallowedCharacters(str, { | |||
There was a problem hiding this comment.
Is there an eslint rule to flag these that we should add in to the esm eslint config of ours? @kanadgupta
There was a problem hiding this comment.
@erunion definitely — I can PR that!
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
😬 not sure how this got in here! This PR shuffles functions around a bit to address errors like this:
🧬 QA & Testing
Do tests pass?