Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update getTags() function to handle webhooks #833

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

darrenyong
Copy link
Contributor

@darrenyong darrenyong commented Nov 1, 2023

🚥 Resolves ISSUE_ID

🧰 Changes

I've updated the .getTags() function to be able to handle webhooks as well in preparation for our webhooks support. This makes it so that any webhooks present in the file will have their tags correctly generated and put in the correct category. Prior to this, it was just placing the endpoint pages in random places.

This particular test will fail until the updated webhooks.yaml file on the oas-examples repo is pulled in.

🧬 QA & Testing

Provide as much information as you can on how to test what you've done.

@darrenyong darrenyong requested a review from erunion November 1, 2023 23:42
packages/oas/src/index.ts Show resolved Hide resolved
packages/oas/test/index.test.ts Outdated Show resolved Hide resolved
@darrenyong darrenyong requested a review from erunion November 2, 2023 18:10
@darrenyong darrenyong merged commit 00d0e80 into main Nov 2, 2023
5 checks passed
@darrenyong darrenyong deleted the refactor/update-getTags-to-handle-webhooks branch November 2, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants