Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dropping support for node 12 #440

Merged
merged 3 commits into from
Mar 1, 2022
Merged

feat: dropping support for node 12 #440

merged 3 commits into from
Mar 1, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Feb 16, 2022

⚠️ Do not merge this until the new Github Action workflow has been tagged to the current v6 release series.

🧰 Changes

Node 12 hits EOL in April and with our new action in #437 it'd be nice to start with a clean start, breaking change for folks, so we might as well drop support for Node 12 now and publish a breaking change rather than having to publish another breaking change in a few months.

This also allows us to finally start using optional chaining in this codebase as that was introduced in Node 14.

🧬 QA & Testing

  • All tests still passing?

@erunion erunion added enhancement New feature or request refactor Issues about tackling technical debt labels Feb 16, 2022
@erunion erunion requested a review from kanadgupta February 16, 2022 01:23
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few other places we could swap out:

rdme/bin/rdme

Line 20 in a5e8fdb

if (err && 'message' in err) {

return opts.main || (isUpdate && isUpdate.is_stable);

@erunion erunion requested a review from kanadgupta February 16, 2022 16:38
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner 🎉

@kanadgupta kanadgupta added this to the v7 milestone Feb 23, 2022
@erunion erunion merged commit e1552db into main Mar 1, 2022
@erunion erunion deleted the feat/drop-node12 branch March 1, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants