fix(validate): surface all validation errors #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
bug
erunion
commented
Oct 17, 2022
| @@ -50,8 +50,8 @@ | |||
| "jsonpath": "^1.1.1", | |||
| "mime-types": "^2.1.35", | |||
| "node-fetch": "^2.6.1", | |||
| "oas": "^18.4.4", | |||
| "oas-normalize": "^7.0.0", | |||
| "oas": "^19.0.1", | |||
There was a problem hiding this comment.
Nothing new there that's going to be used within the library, I just released a v19 last week so might as well update it here.
There was a problem hiding this comment.
Do we even use oas anywhere? Nothing comes up during my quick search
There was a problem hiding this comment.
Ignore me, it's used in the reducer.
There was a problem hiding this comment.
We load it in for the reducer command as that code is in oas.
kanadgupta
approved these changes
Oct 17, 2022
|
@kanadgupta No I wouldn't consider this a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This updates our @readme/openapi-parser and oas-normalize dependencies to begin surfacing all validation errors in OpenAPI and Swagger validation.