-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(baseCommand): inform user which project they're making changes to #643
Merged
kanadgupta
merged 10 commits into
main
from
darren/rm-5582-inform-user-were-using-their-stored
Oct 27, 2022
Merged
feat(baseCommand): inform user which project they're making changes to #643
kanadgupta
merged 10 commits into
main
from
darren/rm-5582-inform-user-were-using-their-stored
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will definitely need some copy changes 😂 |
kanadgupta
requested changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small copy suggestions, but the tests and logic look great 🎉
kanadgupta
requested changes
Oct 27, 2022
kanadgupta
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🫡
kanadgupta
deleted the
darren/rm-5582-inform-user-were-using-their-stored
branch
October 27, 2022 23:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
If users are logged in already, we're going to start informing them which account they're using to make changes and to which project changes are being made to since it currently isn't clear.
🧬 QA & Testing
The info warning should be displayed whenever any commands like
openapi
,docs
,changelog
are being used. It shouldn't show up if the user is logged out and there aren't any saved/stored credentials.