Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(baseCommand): inform user which project they're making changes to #643

Merged
merged 10 commits into from
Oct 27, 2022

Conversation

darrenyong
Copy link
Contributor

🚥 Fix RM-5582

🧰 Changes

If users are logged in already, we're going to start informing them which account they're using to make changes and to which project changes are being made to since it currently isn't clear.

🧬 QA & Testing

The info warning should be displayed whenever any commands like openapi, docs, changelog are being used. It shouldn't show up if the user is logged out and there aren't any saved/stored credentials.

@darrenyong
Copy link
Contributor Author

I will definitely need some copy changes 😂

@kanadgupta kanadgupta added this to the v8 milestone Oct 27, 2022
@darrenyong darrenyong marked this pull request as ready for review October 27, 2022 18:30
@darrenyong darrenyong requested a review from kanadgupta October 27, 2022 18:31
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small copy suggestions, but the tests and logic look great 🎉

__tests__/index.test.ts Outdated Show resolved Hide resolved
src/lib/baseCommand.ts Outdated Show resolved Hide resolved
__tests__/index.test.ts Outdated Show resolved Hide resolved
__tests__/index.test.ts Outdated Show resolved Hide resolved
__tests__/index.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🫡

@kanadgupta kanadgupta merged commit 1bb2448 into main Oct 27, 2022
@kanadgupta kanadgupta deleted the darren/rm-5582-inform-user-were-using-their-stored branch October 27, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants