Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(README): auto-replace major pkg version in Action code blocks #21

Closed
wants to merge 5 commits into from

Conversation

cvan
Copy link
Contributor

@cvan cvan commented Jul 8, 2023

🚥 Fixes #9, enhances #20

🧰 Changes

Changes …micro@v30.2.1 to …micro@v30 (semver major tag).

See PR #20 and issue #9 for context.

🧬 QA & Testing

Try publishing package locally with npm, but discard - do not push to the registry.

Copy link
Member

@domharrington domharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work for both the github action and bitbucket pipeline files?

The github action code sample should display the major version only, but the bitbucket pipeline (cos it's using npx) still needs to display the full version. Has this been accounted for?

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
cvan and others added 4 commits September 13, 2023 17:03
Co-authored-by: Dom Harrington <domharrington@users.noreply.github.com>
This auto-increments the version in the snippet for only the GitHub Action.

Bitbucket Pipelines must continue to use the exact version in the `npx` command because
npm disallows a numeric version (e.g., v2) to be re-published.
https://docs.npmjs.com/cli/v9/commands/npm-dist-tag#caveats
@cvan cvan force-pushed the readme-semver-major-versions branch from 4c2d930 to 1e610a6 Compare September 14, 2023 00:03
@cvan cvan requested a review from domharrington September 18, 2023 20:02
@cvan
Copy link
Contributor Author

cvan commented Sep 18, 2023

Does this work for both the github action and bitbucket pipeline files?

it does now, yes

@domharrington
Copy link
Member

Gunna close this for now! We can revisit in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add util postversion hook to repush major version tag
2 participants