Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the hotkeys after search modal has been opened and closed #299

Merged
merged 6 commits into from
May 14, 2024
Merged

Fix the hotkeys after search modal has been opened and closed #299

merged 6 commits into from
May 14, 2024

Conversation

zanderle
Copy link
Collaborator

@zanderle zanderle commented May 1, 2024 •
edited
Loading

Closes #169
Closes #172

@zanderle zanderle requested review from humitos and a team as code owners May 1, 2024 10:45
@zanderle zanderle requested a review from agjohnson May 1, 2024 10:45
humitos
humitos reviewed May 6, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will do a quick local test when I can and merge after that.

src/search.js Outdated Show resolved Hide resolved
@zanderle zanderle requested a review from humitos May 9, 2024 11:41
humitos
humitos approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me! Thanks 👍🏼

@humitos humitos merged commit 48fd4f1 into main May 14, 2024
4 checks passed
@humitos humitos deleted the zanderle/search-close-when-clicking-outside branch May 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd left review comments

@humitos humitos humitos approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@zanderle @humitos @agjohnson @stsewd