Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post on defaulting to Python 3 #57

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Post on defaulting to Python 3 #57

merged 4 commits into from
Feb 12, 2019

Conversation

agjohnson
Copy link
Contributor

We're not yet ready for this to be merged, we have some final pieces and
a release of our docker image to perform before going official with
this.

We're not yet ready for this to be merged, we have some final pieces and
a release of our docker image to perform before going official with
this.
@agjohnson agjohnson added the Status: blocked Issue is blocked on another issue label Jan 12, 2019
default-python-3.rst Outdated Show resolved Hide resolved
@humitos
Copy link
Member

humitos commented Jan 13, 2019

Linking the PR that contains the docker image modifications for this readthedocs/readthedocs-docker-images#84 and the issue onder .org repo defaulting to Python3 readthedocs/readthedocs.org#3581

@humitos humitos removed the Status: blocked Issue is blocked on another issue label Jan 15, 2019
@humitos
Copy link
Member

humitos commented Jan 15, 2019

Unblocking this since we are close to make Python3 the default. We should take a look at the feedback only.

@agjohnson
Copy link
Contributor Author

agjohnson commented Feb 8, 2019

I updated this post a bit. In intersphinx links, I noticed our RTD docs have a bad version number, so this might depend on readthedocs/readthedocs.org#5259 as well.

Or at least we should wipe out our env and rebuild our blog after that PR is merged.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the date here, think it's good to go. @agjohnson want to push the button? 👍

@agjohnson agjohnson merged commit b554208 into master Feb 12, 2019
@agjohnson agjohnson deleted the agj/default-python3 branch February 12, 2019 19:51
@agjohnson
Copy link
Contributor Author

The buttons have been pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants