Disable no-else-return #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want this enabled, but it seems that it's buggy at the moment. We exclude it for now.
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Aug 30, 2018
|
But the reported files really have a return else. |
|
Closing as invalid. I fixed my PR at readthedocs/readthedocs.org@3087f5b by fixing all the places where this check failed. |
agjohnson
pushed a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Sep 5, 2018
* Upgrade all packages using pur for reqs in `ls requirements`; do pur --skip django-tastypie,django,docker,elasticsearch,pyelasticsearch,commonmark,stripe,djangorestframework,mkdocs,django-allauth,django-filter,mercurial --requirement requirements/$reqs; done * Run lint with Python 3.6 * Downgrade gitpython to 2.1.10 * Linting error fixed * Upgrade common Branch: readthedocs/common#17 * Remove old note for testing * Add note for django-filter * no-else-return fixed in all the files Some block needed to be re-idented to fulfill this check. Basically, if you have a "if something: return another" the "else" clause is not needed since it will be the common case for the flow to continue if the condition is not met. * Only # noqa comment * Note about gitpython
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want this enabled, but it seems that it's buggy at the moment. We
exclude it for now.