Flight hard stop #772
Merged
Flight hard stop #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some advertisers running a time sensitive event want a hard stop date for their flight.
ericholscher
approved these changes
Jul 18, 2023
adserver/tasks.py
Outdated
Comment on lines
1042
to
1043
| if flight.clicks_remaining() <= 0 and flight.views_remaining() <= 0: | ||
| continue |
There was a problem hiding this comment.
Could probably use a comment. Are we skipping this because it finished properly?
Suggested change
| if flight.clicks_remaining() <= 0 and flight.views_remaining() <= 0: | |
| continue | |
| # Don't execute for flights that properly finished | |
| if flight.clicks_remaining() <= 0 and flight.views_remaining() <= 0: | |
| continue |
|
After discussion, I'm thinking about having a "hard stop" boolean and use the |
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
|
I switched |
ericholscher
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some advertisers running a time sensitive event want a hard stop date for their flight.
Right now, the hard stop can only be set in the Django admin but it is displayed to the user when set. The hard stop lowers the impressions/clicks so the flight is completely fulfilled. Then the normal flight wrapup email is sent at the normal time.