Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit classifier to 20k #778

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Limit classifier to 20k #778

merged 1 commit into from
Aug 14, 2023

Conversation

davidfischer
Copy link
Collaborator

Longer inputs can cause massive memory usage and instability.

@davidfischer
Limit classifier to 20k
d1f5ce1 
Longer inputs can cause massive memory usage
and instability.
@davidfischer davidfischer requested review from a team and ericholscher August 11, 2023 22:51
ericholscher
ericholscher approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost certainly the actual fix for memory usage. Do we want to increase this over time, or do we think 20k is enough? It's still a bunch of text.

@davidfischer
Copy link
Collaborator Author

I think 20k is probably enough. That's many pages/screens of actual text.

@davidfischer davidfischer merged commit a1bb723 into main Aug 14, 2023
1 check passed
@davidfischer davidfischer deleted the davidfischer/limit-classifier branch August 14, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfischer @ericholscher