Pricing in server #782
Merged
Pricing in server #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Aug 24, 2023
| self.message = message | ||
|
|
||
| def __call__(self, value): | ||
| from .models import Topic # noqa |
There was a problem hiding this comment.
Guessing there's a reason this is a nested import, but probably good to note it here?
There was a problem hiding this comment.
The validators are used to validate the models. It would be circular without this. I'll note it.
…ple-placements Server can control multiple publisher placements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is branched from the Django 4 upgrade: #781.
Allow advertisers to select regions and topics when requesting a flight. Based on what they specify, an estimated CPM will be shown. Prices per region/topic will be stored in a JSON field on the region model. Regions and topics will have an option whether they can be selected by advertisers when requesting a new flight.
Screenshot