Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all dependencies #895

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Upgrade all dependencies #895

merged 5 commits into from
Jul 16, 2024

Conversation

ericholscher
Copy link
Member

This uses pip-compile -U to update all deps to their latest versions.

This uses pip-compile -U to update all deps to their latest versions.
@ericholscher ericholscher requested a review from a team as a code owner July 10, 2024 22:12
requirements/base.txt Outdated Show resolved Hide resolved
@davidfischer
Copy link
Collaborator

I fixed a few test issues and implemented the #893 change in here.

Replaces #893.

- Replaces black, pylint, reorder-imports, and prospector
- Slight changes in style preferences although pretty configurable
Use ruff formatter for code style and linting
@ericholscher
Copy link
Member Author

@davidfischer Thanks for cleaning up the tests here. I think we should be good to move forward here, but this release will definitely require a good bit more testing. I know in the past we've hit some issues upgrading Sentry & New Relic as well, which will be harder to test in dev.

Probably makes sense to merge this and test it in dev for a week or so before going fully live, and then doing strong QA on it. If we don't have any short-term changes to make, I think it should be good to merge now.

@davidfischer davidfischer merged commit 1004a52 into main Jul 16, 2024
1 check passed
@davidfischer davidfischer deleted the update-deps branch July 16, 2024 19:28
@davidfischer
Copy link
Collaborator

Probably makes sense to merge this and test it in dev for a week or so before going fully live, and then doing strong QA on it. If we don't have any short-term changes to make, I think it should be good to merge now.

That sounds good to me. I have run the full test suite and ran it in dev, but I agree. Having a PR with a bunch of upgrades was causing some work slowdown because the env was in a weird state so I'm glad to have this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants