Migrate JSONField to Django builtin JSONField

[ericholscher]

This runs a migration that converts from text to jsonb.

In my local testing it converted the field properly:

ethicaladserver=# select targeting_parameters from adserver_flight;
    targeting_parameters
----------------------------
 {                         +
     "niche_targeting": 0.9+
 }
(1 row)

ethicaladserver=# select targeting_parameters from adserver_flight;
   targeting_parameters
--------------------------
 {"niche_targeting": 0.9}
(1 row)

[davidfischer]

Not sure what the deal is with simple history, but sans that this looks good.

[davidfischer]

Not sure what the deal is with simple history, but sans that this looks good.

I'll take a look at this and see if I can't resolve the issue.

[davidfischer]

The test failures seem to be a result of jazzband/django-simple-history#1181 which is still open. We may have to either ignore historical changes on jsonfields, stop adding a change reason (remove calls to update_change_reason), or wait on updating our JSONFields.

[ericholscher]

FWIW, I never look at update_change_reason, though that's mostly because simple history doesn't do diffs, so the history is mostly useless to understand what changed.

[davidfischer]

I created a PR #924 to remove update_change_reason so we can move forward with this.

[ericholscher]

Cool. Let's plan to get it merged and deployed next week. 👍