Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to py3 for new conda projects #86

Closed
humitos opened this issue Jan 14, 2019 · 2 comments · Fixed by #166
Closed

Default to py3 for new conda projects #86

humitos opened this issue Jan 14, 2019 · 2 comments · Fixed by #166
Labels
Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Jan 14, 2019

Considering that we are defaulting to python3 for new projects (readthedocs/readthedocs.org#3581) we need to do the same for projects that uses conda instead of pip.

This can be achieved by using Miniconda3 instead of Miniconda2. The problem of changing this is that if the user was not specifying the Python version, python2 was installed and now python3 will be installed, which may break the build.

We need to research a little more about this and make some tests.

Discussion: #84 (comment)
@humitos humitos added the Improvement Minor improvement to code label Jan 14, 2019
@humitos
Copy link
Member Author

humitos commented Jul 18, 2019

The problem of changing this is that if the user was not specifying the Python version, python2 was installed and now python3 will be installed, which may break the build.

I think we should start forcing this. We are close to the end of the Python2 support and people using conda environment usually specifies the version of Python they want to install in the environment.yml file.

@humitos humitos mentioned this issue Jul 18, 2019
Closed
@humitos humitos mentioned this issue Dec 21, 2020
Closed
humitos added a commit that referenced this issue Jul 8, 2021
@humitos
Add support for Python 3.10.0b3 and upgrade to Miniconda3-4.9.2
8a6a879 
Install Python 3.10.0b3 and upgrade to Miniconda3-py38-4.9.2.

> NOTE that Miniconda3-py39_4.10.1 is not available for Linux x86_64 so I had to
> pick the previous one

Upgrading Miniconda2 to Miniconda3 changes the default behavior when the user
doesn't specify the python version (`build.python.version`). The environment
will be created with Python3 by default now instead of Python2.
See #86

I don't think this will affect too many users since this PR is going to be
merged into `release/7.x` branch (`testing` image) that only a few users are
currently using.
@humitos humitos mentioned this issue Jul 8, 2021
Merged
@humitos
Copy link
Member Author

humitos commented Sep 2, 2021

New Docker images (#166) will require the user to explicity define the conda version they want to install. If the select miniconda2-* it will use Python2 as the default. Otherwise, if they specify miniconda3-*, it will use Python3.

We don't need to take any other action here.

@humitos humitos mentioned this issue Sep 2, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
1 participant
@humitos