Skip to content

Commit

Permalink
Proxito: unskip test (#9559)
Browse files Browse the repository at this point in the history
Ref #9557
  • Loading branch information
stsewd authored Aug 30, 2022
1 parent 7d91b7c commit 1fd6a66
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
10 changes: 7 additions & 3 deletions readthedocs/proxito/tests/handler_404_urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,18 @@
def map_proxito_path(view_func):

@wraps(view_func)
def inner_view(request, exception, *args, **kwargs):
def inner_view(request, *args, **kwargs):
return view_func(
request,
*args,
proxito_path=request.path,
**kwargs,
)
return inner_view


handler404 = map_proxito_path(ServeError404.as_view())

# Patch URLs that call the `fast_404` view directly.
for pattern in urlpatterns:
if getattr(pattern, "name", None) == "docs_detail_directory_indexing":
pattern.callback = handler404
break
3 changes: 0 additions & 3 deletions readthedocs/proxito/tests/test_old_redirects.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,6 @@ def test_redirect_exact(self):
'http://project.dev.readthedocs.io/en/latest/tutorial/install.html',
)

@pytest.mark.xfail(
reason="This is hitting fast_404 and not triggering the nginx handler in testing. It works in prod."
)
def test_redirect_exact_looks_like_version(self):
fixture.get(
Redirect,
Expand Down

0 comments on commit 1fd6a66

Please sign in to comment.