Skip to content

Commit

Permalink
Merge pull request #4133 from italia/logexception
Browse files Browse the repository at this point in the history
oauth/services: don't abuse log.exception
  • Loading branch information
ericholscher authored May 24, 2018
2 parents b02526f + 086b061 commit 40ee834
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions readthedocs/oauth/services/bitbucket.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def setup_webhook(self, project):
project,
)
else:
log.exception(
log.error(
'Bitbucket webhook creation failed for project: %s',
project,
)
Expand Down Expand Up @@ -287,7 +287,7 @@ def update_webhook(self, project, integration):
project,
)
else:
log.exception(
log.error(
'Bitbucket webhook update failed for project: %s',
project,
)
Expand Down
4 changes: 2 additions & 2 deletions readthedocs/oauth/services/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def setup_webhook(self, project):
project,
)
else:
log.exception(
log.error(
'GitHub webhook creation failed for project: %s',
project,
)
Expand Down Expand Up @@ -274,7 +274,7 @@ def update_webhook(self, project, integration):
project,
)
else:
log.exception(
log.error(
'GitHub webhook update failed for project: %s',
project,
)
Expand Down
4 changes: 2 additions & 2 deletions readthedocs/oauth/services/gitlab.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def setup_webhook(self, project):
project,
)
else:
log.exception(
log.error(
'GitLab webhook creation failed for project: %s',
project,
)
Expand Down Expand Up @@ -363,7 +363,7 @@ def update_webhook(self, project, integration):
log.exception(
'GitLab webhook update failed for project: %s', project)
else:
log.exception(
log.error(
'GitLab webhook update failed for project: %s',
project,
)
Expand Down

0 comments on commit 40ee834

Please sign in to comment.