Merge pull request #5945 from readthedocs/fix-sphinxdomain-delete

Explicitly delete SphinxDomain objects from previous versions
readthedocs · Jul 17, 2019 · 5390828 · 5390828
2 parents 2888d2e + b86b1b1
commit 5390828
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/readthedocs/projects/tasks.py b/readthedocs/projects/tasks.py
@@ -1494,6 +1494,16 @@ def _sync_imported_files(version, build, changed_files):
         build=build,
     )
 
+    # Delete SphinxDomain objects from previous versions
+    # This has to be done before deleting ImportedFiles and not with a cascade,
+    # because multiple Domain's can reference a specific HTMLFile.
+    (
+        SphinxDomain.objects
+        .filter(project=version.project, version=version)
+        .exclude(build=build)
+        .delete()
+    )
+
     # Delete ImportedFiles objects (including HTMLFiles)
     # from the previous build of the version.
     (