Merge pull request #5326 from stsewd/protect-against-api-failure

Don't depend on specific data when catching exception
readthedocs · Feb 21, 2019 · ed8dd29 · ed8dd29
2 parents 55105bb + 8376557
commit ed8dd29
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/readthedocs/projects/tasks.py b/readthedocs/projects/tasks.py
@@ -390,8 +390,11 @@ def run(
                     'stack': True,
                     'tags': {
                         'build': build_pk,
-                        'project': self.project.slug,
-                        'version': self.version.slug,
+                        # We can't depend on these objects because the api
+                        # could fail. But self.project and self.version are
+                        # initialized as empty dicts in the init method.
+                        'project': self.project.slug if self.project else None,
+                        'version': self.version.slug if self.version else None,
                     },
                 },
             )