Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: document our CORS rules for docs pages #10836

Closed
stsewd opened this issue Oct 17, 2023 · 0 comments · Fixed by #10853
Closed

Docs: document our CORS rules for docs pages #10836

stsewd opened this issue Oct 17, 2023 · 0 comments · Fixed by #10853
Labels
Needed: documentation Documentation is required

Comments

@stsewd
Copy link
Member

stsewd commented Oct 17, 2023

What's the problem this feature will solve?

We recently changed our CORS header for documentation files, we don't have any of this documented.

Describe the solution you'd like

We should document how our CORS rules work for docs pages, security implications (none, at least users are doing something custom proxying to us or similar). Similar to what we have in https://docs.readthedocs.io/en/stable/api/cross-site-requests.html.

@stsewd stsewd added the Needed: documentation Documentation is required label Oct 17, 2023
stsewd added a commit that referenced this issue Oct 19, 2023
stsewd added a commit that referenced this issue Jan 22, 2024
* Docs: document CORS policies

Closes #10836

* Updates from review

* Include in toctree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: documentation Documentation is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant