Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade django-pagination #3664

Closed
humitos opened this issue Feb 23, 2018 · 6 comments
Closed

Upgrade django-pagination #3664

humitos opened this issue Feb 23, 2018 · 6 comments
Labels
Improvement Minor improvement to code
Milestone

Comments

@humitos
Copy link
Member

humitos commented Feb 23, 2018

We are using a fork of the unmaintained django-pagination (https://github.com/zyga/django-pagination).

On the other hand, I found that there is another fork that maybe is more maintained at https://github.com/pydanny/dj-pagination

I opened an issue that the 3dparty repository at zyga/django-pagination#42

Ref #2435

@humitos humitos added the Improvement Minor improvement to code label Feb 23, 2018
@humitos humitos added this to the Refactoring milestone Feb 23, 2018
humitos added a commit that referenced this issue Feb 23, 2018
Closes #3664

The package `django-pagination` got unmaintained, so a fork by Linaro
was created at https://github.com/zyga/django-pagination and got
unmaintained again (zyga/django-pagination#42).

Now, there is another fork at https://github.com/pydanny/dj-pagination)
that contains more compatibility releases. So, I'm upgrading to this one.
@pydanny
Copy link
Contributor

pydanny commented Feb 24, 2018

We use dj-pagination on a single project, but I have to admit it has a few glitches.

@humitos
Copy link
Member Author

humitos commented Feb 26, 2018

@pydanny thanks for your comment.

We don't use it in a heavy way, there are just a couple of pages that list

  • the buils
  • the projects
  • search results (I think)

So, we won't probably be bitten for those glitches at this point and I think that the current version is more compatible with Py3 that the one that we have pinned at a specific commit.

(another option is to consider refactor this code to remove this dependency, but that would probably more complicated)

@pydanny
Copy link
Contributor

pydanny commented Feb 26, 2018

Well, if you find any glitches with dj-pagination, let me know by mentioning RTD or RTFD in the issue. I'll move fixing them to the top of my priority queue.

It's the least I can do for you in return for all the awesomeness RTD provides to the universe.

@RichardLitt
Copy link
Member

@ericholscher Do we have a list of great comments from really super nice people somewhere? If so, we should add this. :)

@ericholscher
Copy link
Member

@RichardLitt we don't! That sounds like a good idea though, as a morale boost for some days when we're feeling down. Perhaps similar to testimonials in our docs?

@RichardLitt
Copy link
Member

@ericholscher Exactly. Maybe somewhere just internally at the company. It's a silly idea, but it helps you feel good. :) You'd know best on where to put it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

4 participants