Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused validations from v1 config #4706

Closed
stsewd opened this issue Oct 2, 2018 · 2 comments
Closed

Remove unused validations from v1 config #4706

stsewd opened this issue Oct 2, 2018 · 2 comments
Assignees
@stsewd
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone
Cleanup

Comments

@stsewd
Copy link
Member

stsewd commented Oct 2, 2018

validate_base and validate_name don't have any purpose here, and we rather re-purpose those for v2.

related code:

https://github.com/rtfd/readthedocs.org/blob/a98441717ea50b19fe6bb0f1ea52df092dbc8190/readthedocs/config/config.py#L282-L309
@stsewd stsewd added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Oct 2, 2018
@stsewd stsewd added this to the Cleanup milestone Oct 2, 2018
@stsewd stsewd mentioned this issue Oct 2, 2018
Merged
@stsewd stsewd self-assigned this Nov 2, 2018
@stsewd stsewd mentioned this issue Nov 9, 2018
Merged
@stsewd stsewd removed the Needed: design decision A core team decision is required label Nov 19, 2018
@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
@stsewd
Copy link
Member Author

stsewd commented Jan 10, 2019

We have a open PR for this bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stsewd stsewd

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
Cleanup
Development

No branches or pull requests
1 participant
@stsewd