-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused validations from v1 config #4883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4883 +/- ##
=========================================
- Coverage 76.74% 76.5% -0.24%
=========================================
Files 158 158
Lines 9951 10004 +53
Branches 1244 1264 +20
=========================================
+ Hits 7637 7654 +17
- Misses 1980 2008 +28
- Partials 334 342 +8
|
f93fc19
to
9d787aa
Compare
Ok, this is ready for review, global coverage drop is expected because we are removing a lot of code here. Coverage is looking good https://codecov.io/gh/rtfd/readthedocs.org/pull/4883/src/readthedocs/config/config.py?before=readthedocs/config/config.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand it 100% but looks good.
It seems that we are not using base
and name
in the same way in V2. I'm assuming that V1 now uses a shared code with V2 and these checks are still performed but in a different way. If my assumption is true, I'd say that this is 👍
We never used that in v1, we were giving some defaults (constant strings actually) from the rtd code, and we never used those values, in v2 we have the multiple installations thing that makes what Here https://github.com/rtfd/readthedocs.org/pull/4883/files#diff-8b90ee75bb4ed7a0341eac84832b7ea7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Feel free to merge when you consider ;)
Close #4706
I'm labeling this as wip because we still can delete more code from tests, but it will conflict with #4800, so waiting to get that one merged first