Proxito: inject hosting integration header for build.commands
#10219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions using `build.commands` will start using the new Read the Docs JavaScript client. This is still under beta testing, but we want to move forward slowly and start exposing these features to projects that don't have access currently. Related readthedocs/addons#26
ericholscher
approved these changes
Apr 6, 2023
|
I'm marking this PR as blocked for now until we have everything in place. We are pretty close, but we want to merge other PRs first, I guess. |
humitos
added a commit
that referenced
this pull request
May 23, 2023
This `addons` field will be used to tell El Proxito this version was built using `build.commands`. Then, El Proxito will use this field to inject the HTTP header that tells Cloudflare that it should inject the new JS client. This commit is a replacement of #10219 to avoid the time-consuming query that checks the config file of the latest build for the version. Closes #10331
humitos
added a commit
that referenced
this pull request
May 24, 2023
* Version: new field `addons` This `addons` field will be used to tell El Proxito this version was built using `build.commands`. Then, El Proxito will use this field to inject the HTTP header that tells Cloudflare that it should inject the new JS client. This commit is a replacement of #10219 to avoid the time-consuming query that checks the config file of the latest build for the version. Closes #10331 * Proxito: improve query - return only the field we need ("addons") - only check for `version.addons` if the project doesn't have the feature * Tests: add test for El Proxito header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions using
build.commandswill start using the new Read the Docs JavaScript client.This is still under beta testing, but we want to move forward slowly and start exposing these features to projects that don't have access currently.
Related readthedocs/addons#26