-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxito: always use subdomain for serving docs #10799
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -200,12 +200,7 @@ def process_request(self, request): # noqa | |
request.unresolved_domain = None | ||
|
||
skip = any(request.path.startswith(reverse(view)) for view in self.skip_views) | ||
if ( | ||
skip | ||
or not settings.USE_SUBDOMAIN | ||
or "localhost" in request.get_host() | ||
or "testserver" in request.get_host() | ||
Comment on lines
-206
to
-207
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These two checks are not really that useful, and they cause problems if your project has There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hrm, I feel like it might cause some issues in tests, but if everythings looks OK, I agree this is a better approach. |
||
): | ||
if skip: | ||
log.debug("Not processing Proxito middleware") | ||
return None | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not still need this logic to determine cname usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not when resolving the path, only when resolving the domain