Addons: resolve versions/translations URLs properly #10821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use our `Resolver.resolve` logic to resolve versions/translations URLs for the flyout menu. This makes it work URLs for subprojects and translations as well. Closes readthedocs/addons#158
stsewd
reviewed
Oct 16, 2023
ericholscher
approved these changes
Oct 16, 2023
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
humitos
commented
Oct 17, 2023
stsewd
reviewed
Oct 17, 2023
humitos
added a commit
that referenced
this pull request
Oct 17, 2023
humitos
added a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use our
Resolver.resolvelogic to resolve versions/translations URLs for theflyout menu. This makes it work URLs for subprojects and translations as well.
Closes readthedocs/addons#158