Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation around version warning banner #10877

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

jertel
Copy link
Contributor

@jertel jertel commented Oct 30, 2023

Relates to issue: #8789 (comment)
Closes #6096
Closes #8789

This updates the Version warning doc section to communicate the new functionality in an upcoming addon PR (readthedocs/addons#174) and also notes that the feature toggle is currently not visible to all projects.


📚 Documentation previews 📚

@jertel jertel requested a review from a team as a code owner October 30, 2023 12:32
@jertel jertel requested a review from ericholscher October 30, 2023 12:32
@ericholscher ericholscher requested a review from humitos October 30, 2023 19:01
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This is good!

I left some feedback that could improve this section a little more.

docs/user/versions.rst Outdated Show resolved Hide resolved
docs/user/versions.rst Outdated Show resolved Hide resolved
docs/user/versions.rst Outdated Show resolved Hide resolved
docs/user/versions.rst Outdated Show resolved Hide resolved
jertel and others added 3 commits November 7, 2023 12:50
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@humitos humitos merged commit 0691bcb into readthedocs:main Nov 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants