Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version-compare.js #1968

Closed
wants to merge 1 commit into from
Closed

Remove version-compare.js #1968

wants to merge 1 commit into from

Conversation

remram44
Copy link

@remram44 remram44 commented Feb 1, 2016

Fixes #1856 by removing version-compare.js

TODO: rebuild statics

@remram44
Copy link
Author

remram44 commented Feb 1, 2016

Your fabfile doesn't work, lxml doesn't compile without CFLAGS=-I/usr/include/libxml2, the barrier to work on RTD is kinda high...

All that is left is for one of you who had more luck setting up all your dependencies to type "gulp", I give up.

@remram44
Copy link
Author

remram44 commented Feb 1, 2016

Alright after having managed to setup all your Python dependencies, node.js, npm, gulp and all the other npm packages (I had never used npm before; really there should be a better way to setup the project than going through all that just to type "gulp"), I'm hitting some kind of error from god-knows-what.

Warning: gulp-run is deprecated
[20:40:50] Using gulpfile /vagrant/gulpfile.js
[20:40:50] Starting 'build'...
[20:40:50] Building source files
[20:40:57] Browserify error: could not resolve dependency jquery : bower returns the module as known but not found (did you forget to run bower install ?) (/vagrant/readthedocs/core/static-src/core/js/autocomplete.js) while parsing file: /vagrant/readthedocs/core/static-src/core/js/autocomplete.js
[20:40:57] Browserify error: could not resolve dependency readthedocs-client : bower returns the module as known but not found (did you forget to run bower install ?) (/vagrant/readthedocs/projects/static-src/projects/js/tools.js) while parsing file: /vagrant/readthedocs/projects/static-src/projects/js/tools.js
[20:40:57] Browserify error: could not resolve dependency jquery : bower returns the module as known but not found (did you forget to run bower install ?) (/vagrant/readthedocs/gold/static-src/gold/js/gold.js) while parsing file: /vagrant/readthedocs/gold/static-src/gold/js/gold.js
[20:40:57] Browserify error: could not resolve dependency knockout : bower returns the module as known but not found (did you forget to run bower install ?) (/vagrant/readthedocs/projects/static-src/projects/js/import.js) while parsing file: /vagrant/readthedocs/projects/static-src/projects/js/import.js
[20:40:57] Browserify error: could not resolve dependency knockout : bower returns the module as known but not found (did you forget to run bower install ?) (/vagrant/readthedocs/builds/static-src/builds/js/detail.js) while parsing file: /vagrant/readthedocs/builds/static-src/builds/js/detail.js
[20:40:57] Browserify error: could not resolve dependency jquery : bower returns the module as known but not found (did you forget to run bower install ?) (/vagrant/readthedocs/donate/static-src/donate/js/donate.js) while parsing file: /vagrant/readthedocs/donate/static-src/donate/js/donate.js
[20:40:57] Browserify error: could not resolve dependency sphinx-rtd-theme : bower returns the module as known but not found (did you forget to run bower install ?) (/vagrant/readthedocs/core/static-src/core/js/doc-embed/sphinx.js) while parsing file: /vagrant/readthedocs/core/static-src/core/js/doc-embed/sphinx.js

@agjohnson
Copy link
Contributor

Instead of directing your anger at the maintainers because you are unfamiliar with the toolchain, try to raise a reasonable issue with our documentation. Calling it shit for the sake of calling it shit doesn't serve any purpose.

Our front end toolchain workflow is documented in length here:
http://docs.readthedocs.org/en/latest/development/standards.html#development-standards

@pydanny
Copy link
Contributor

pydanny commented Feb 2, 2016

@remram44 You are not helping with your attitude. Not at all. Your attitude kills open source projects. Not with a project mostly powered by unpaid volunteers. A better way to handle this sort of issue is to do the following:

  1. Open an issue politely stating that the project could use better documentation in the area of your complaint.
  2. (optional) Take your notes on getting things working and submit them as a pull request. That way, instead of just raising an issue, you are actually fixing the problem.

@remram44
Copy link
Author

remram44 commented Feb 2, 2016

All that's left is for one of you team members, who know how your frontend setup works, to run "gulp". Surely you'll manage.

As for your doc, I just want you to know that I lost that much time. That your fabfile doesn't work on Debian because of lxml. Fix it or not, I don't really care, now I have to handle the public shaming that your co-founder unleashed on me on Twitter instead (really makes me miss not being a part of your community... or does it?)

@remram44 remram44 closed this Feb 2, 2016
@pydanny
Copy link
Contributor

pydanny commented Feb 3, 2016

@remram44 I thought about your discussion here and I realized I probably came on too strong. I should have tried to work through things with you in a more rational manner. You seem passionate about doing stuff and that's awesome. Why not be friends? I've made friends through adversity before, why not now?

I really was about to try. And then...

Then I noticed the nasty parts of your comments were gone. Changed. You took them out. Deleted them. No longer do you complain bitterly about a documentation site that doesn't document its installation to standard you demand.

At first I was infuriated. But then I realized that's the wrong way.

Why?

Because I think you removed those comments because you, like me, realized we were going down the wrong path. And you know what? I can understand why you might have deleted the more angry part of your writing in this pull request.

So let's not fight. Let's work together. Instead of bickering, let's channel our passion for open source and make awesome stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants