Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed <strong> from html to css #2699

Closed
wants to merge 1 commit into from
Closed

changed <strong> from html to css #2699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions readthedocs/donate/templates/donate/promo_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@

{% block content %}

<style>

p.strong {
font-weight: bold;
}
</style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use inline styles, you'll find our css at media/css/core.css


<h1> Promo Results </h1>

{% if promos %}
Expand All @@ -32,10 +39,10 @@ <h3>

<table>
<tr>
<th><strong>Day (UTC)</strong></th>
<th><strong>Views</strong></th>
<th><strong>Clicks</strong></th>
<th><strong>CTR</strong></th>
<th><p class ="strong">Day (UTC)</p></th>
<th><p class ="strong">Views</p></th>
<th><p class ="strong">Clicks</p></th>
<th><p class ="strong">CTR</p></th>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feedback to the original approach was that this didn't need to use <strong> tags on each cell. Instead of applying <strong> or <p class="strong"> to each <th>, we should instead be applying a heavier weight to the table tr th css selector.

</tr>
{% for day in promo.impressions.all|slice:days_slice %}
{% if day.views > 0 %}
Expand All @@ -48,10 +55,10 @@ <h3>
{% endif %}
{% endfor %}
<tr>
<td><strong>Total (over all time)</strong> </td>
<td><strong>{{ promo.total_views }}</strong></td>
<td><strong>{{ promo.total_clicks }}</strong></td>
<td><strong>{{ promo.total_click_ratio }}%</strong></td>
<td><p class ="strong">Total (over all time)</p> </td>
<td><p class ="strong">{{ promo.total_views }}</p></td>
<td><p class ="strong">{{ promo.total_clicks }}</p></td>
<td><p class ="strong">{{ promo.total_click_ratio }}%</p></td>
</tr>
</table>

Expand Down