Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow superusers to pass admin & member tests for projects #3335

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

ericholscher
Copy link
Member

No description provided.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine here, but this should be tested on the commercial hosting. I believe this only affects a few spots where we explicitly look for a permission on an action?

We'll need a ticket created if it does interfere to track that work.

@agjohnson
Copy link
Contributor

Also, what is the context for this change? A description here would be helpful.

@ericholscher
Copy link
Member Author

Mostly I want to be able to trigger builds for users, which is now hidden behind an admin block. But it will also be useful for other places we're running the check as well, so we can see more info.

@ericholscher
Copy link
Member Author

Believe the .com overrides these methods, so it shouldn't have much effect.

@agjohnson
Copy link
Contributor

Roger 👍

@agjohnson agjohnson merged commit 7a66f6f into master Nov 30, 2017
@agjohnson agjohnson deleted the allow-super-access branch November 30, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants