Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add woff2 #3602

Closed
wants to merge 2 commits into from
Closed

add woff2 #3602

wants to merge 2 commits into from

Conversation

fiennyangeln
Copy link

@fiennyangeln fiennyangeln commented Feb 13, 2018

Added woff2

Closes #3586

CHANGELOG.rst Outdated
@@ -1,6 +1,6 @@
Version 2.1.6
-------------

* `@fiennyangeln <http://github.com/fiennyangeln>`_: Add woff2 (`#3586 <https://github.com/rtfd/readthedocs.org/issues/3586>`_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to edit the changelog here, this is done automatically (or almost #3524)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I will change it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed! thanks

@davidfischer
Copy link
Contributor

This looks good.

What version of fontawesome is this? It doesn't seem to match the sha hash of the one from https://github.com/FortAwesome/Font-Awesome/releases/tag/v4.6.3.

@davidfischer davidfischer mentioned this pull request May 4, 2018
@ericholscher
Copy link
Member

I believe this actually got done in another PR. Thanks for this change though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants