Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments app #3618

Closed
wants to merge 1 commit into from
Closed

Conversation

shreyateeza
Copy link
Contributor

readthedocs.comments.models.ModerationActionManager is unimplemented. This is a cleanup issue.

Closes #2879

readthedocs.comments.models.ModerationActionManager is unimplemented. This is a cleanup issue.

Closes readthedocs#2879
@Tikam02
Copy link

Tikam02 commented Feb 15, 2018

@shreyateeza so what's the error causing travis to "All checks have failed". Because there are many issues regarding "Comment" app.

@shreyateeza
Copy link
Contributor Author

@Tikam02 It means that first the rest issues needs to be merged/closed then only travis-ci will succeed. Right?

@stsewd
Copy link
Member

stsewd commented Feb 15, 2018

@shreyateeza There is a import error https://travis-ci.org/rtfd/readthedocs.org/jobs/341953589#L844, you should update/delete some tests.

@Tikam02
Copy link

Tikam02 commented Feb 15, 2018

yup that's what i was referring import error.

@ericholscher
Copy link
Member

Would love to see someone take this across the finish line, by deleting the tests too! I would love to merge this :)

@shreyateeza
Copy link
Contributor Author

@ericholscher I am working on this issue!

@ericholscher
Copy link
Member

@shreyateeza Glad to hear it! Thank you :)

@RichardLitt RichardLitt added the PR: work in progress Pull request is not ready for full review label Feb 22, 2018
@humitos
Copy link
Member

humitos commented Mar 14, 2018

@shreyateeza any news on this? We were close to merge it. I'd like to get this done and merged.

Please, if you don't have more time to finish it let us know so someone else can continue your work.

@shreyateeza
Copy link
Contributor Author

@humitos Yes you can assign this issue to someone else.
I am really sorry for not completing this.

@RichardLitt
Copy link
Member

@shreyateeza No need to apologise at all! We're mostly volunteer run, and we all understand. Contribute what you can whenever you can, if you want. :)

@humitos
Copy link
Member

humitos commented Mar 23, 2018

I'm closing this one in favor of #3802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: work in progress Pull request is not ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants