#3741: replaced Go Crazy text with Search #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Mar 7, 2018
| @@ -24,7 +24,7 @@ | |||
| <input type="hidden" name="selected_facets" value="{{ selected_facets }}" id='id_selected_facets'> | |||
| </div> | |||
| <div class="submit-input-wrapper"> | |||
| <input type="submit" value="{% trans "Go crazy." %}" id="id_search_button"> | |||
| <input type="submit" value='{% trans "Search" %}' id="id_search_button"> | |||
There was a problem hiding this comment.
You shouldn't change the double quotes to single quotes here, html needs ".
There was a problem hiding this comment.
"{% trans 'search' %}"
This syntax will do i guess. I think both shall not be double quotes.. Do correct me if i'm wrong
stsewd
reviewed
Mar 7, 2018
| @@ -14,7 +14,7 @@ | |||
| </div> | |||
| <div class="submit-input-wrapper"> | |||
| {% comment %}Translators: This is about starting a search{% endcomment %} | |||
| <input type="submit" value="{% trans "Go crazy." %}"> | |||
| <input type="submit" value='{% trans "Search" %}' | |||
There was a problem hiding this comment.
I think you removed the > accidentally here
There was a problem hiding this comment.
oops.. my bad :D I'll correct it for sure :)
RichardLitt
approved these changes
Mar 7, 2018
Closed
|
I'm glad someone was able jump in and clean this up, thanks for the contribution @rajujha373 ! 🎉 |
|
@agjohnson and @RichardLitt thank you so much guys ... This is my first merged changes in readthedocs... Yayy 🥇 🎉 |
|
Well done, @rajujha373! Welcome to the family. Make yourself at home. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.